docs: update ImagePart refdocs #6681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Javadoc Changes:--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/vertexai/type/ImagePart.html 2025-02-17 13:45:08.164930195 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/vertexai/type/ImagePart.html 2025-02-17 13:43:00.353474468 +0000
@@ -11,7 +11,7 @@
<pre>public final class <a href="/docs/reference/android/com/google/firebase/vertexai/type/ImagePart.html">ImagePart</a> implements <a href="/docs/reference/android/com/google/firebase/vertexai/type/Part.html">Part</a></pre>
</p>
<hr>
- <p>Represents image data sent to and received from requests. When this is sent to the server it is converted to jpeg encoding at 80% quality.</p>
+ <p>Represents image data sent to and received from requests. The image is converted client-side to JPEG encoding at 80% quality before being sent to the server.</p>
<h2>Summary</h2>
<div class="devsite-table-wrapper">
<table class="responsive">--- /home/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/vertexai/type/ImagePart.html 2025-02-17 13:45:08.173930224 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/vertexai/type/ImagePart.html 2025-02-17 13:43:00.360474493 +0000
@@ -11,7 +11,7 @@
<pre>class <a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/ImagePart.html">ImagePart</a> : <a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/Part.html">Part</a></pre>
</p>
<hr>
- <p>Represents image data sent to and received from requests. When this is sent to the server it is converted to jpeg encoding at 80% quality.</p>
+ <p>Represents image data sent to and received from requests. The image is converted client-side to JPEG encoding at 80% quality before being sent to the server.</p>
<h2>Summary</h2>
<div class="devsite-table-wrapper">
<table class="responsive"> |
Test Results 20 files + 12 20 suites +12 12s ⏱️ -7s Results for commit 4c504da. ± Comparison against base commit f80ba89. This pull request removes 22 and adds 114 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
firebase-vertexai/src/main/kotlin/com/google/firebase/vertexai/type/Part.kt
Outdated
Show resolved
Hide resolved
…/type/Part.kt Co-authored-by: rachelsaunders <[email protected]>
Generated by 🚫 Danger |
Coverage Report 1Affected ProductsNo changes between base commit (ed5621e) and merge commit (c0f608d).Test Logs |
rachelsaunders
approved these changes
Feb 7, 2025
Size Report 1Affected ProductsNo changes between base commit (ed5621e) and merge commit (c0f608d).Test Logs |
rlazo
approved these changes
Feb 11, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current refdocs are somewhat confusing and may lead to assume that the conversion happens server-side, when it's actually client side.